sync changes #2
sync changes #2
Conversation
There was a problem hiding this comment.
Hi, I am taking the occasion for introducing you to the magic world of PR reviews 💃
You will hate me, but then when you will have to make a PR to code freaks (I mean to semi-professional software engineers) you will be already in control of good commit practices ;)
| //std::vector<ttH::Lepton> selElectrons; | ||
| //std::vector<ttH::Lepton> selMuons; | ||
| //std::vector<ttH::Lepton> selleptons; | ||
|
|
||
| std::vector<ttH::Dilepton> ll; | ||
| std::vector<ttH::DileptonMet> llmet; | ||
| std::vector<ttH::Dijet> jj; |
There was a problem hiding this comment.
It is usually desirable to not have whiteline removed/added without a specific reason.
I am usually personally quite indifferent to that, but there are very picky persons here and there :)
The general idea is that if you don't really need to remove/add a whiteline there, then there is no reason for having it.
| @@ -13,10 +13,11 @@ | |||
| #include <cp3_llbb/Framework/interface/HLTProducer.h> | |||
|
|
|||
| #include <cmath> | |||
|
|
|||
There was a problem hiding this comment.
Again, whiteline should be added back
plugins/ttHAnalyzer.cc
Outdated
| #define ttH_GEN_DEBUG (false) | ||
| #define TT_GEN_DEBUG (false) | ||
|
|
||
|
|
There was a problem hiding this comment.
No reason to add a whiteline here
| @@ -37,7 +38,6 @@ void ttHAnalyzer::analyze(const edm::Event& event, const edm::EventSetup&, const | |||
| jj.clear(); | |||
| //llmetjj.clear(); | |||
| //llmetjj_cmva.clear(); | |||
|
|
|||
| @@ -339,9 +339,15 @@ void ttHAnalyzer::analyze(const edm::Event& event, const edm::EventSetup&, const | |||
| if (allelectrons.p4[ielectron].Pt() > m_subleadingElectronPtCut | |||
| && fabs(allelectrons.p4[ielectron].Eta()) < m_electronEtaCut) | |||
| { | |||
|
|
|||
plugins/ttHAnalyzer.cc
Outdated
| } | ||
|
|
| int nElectrons=leptons.size(); | ||
| //std::cout<<" # of ele: "<< nElectrons <<std::endl; | ||
| if(nElectrons!=1) return; | ||
|
|
plugins/ttHAnalyzer.cc
Outdated
| }//end of loop on muons | ||
|
|
| @@ -30,7 +30,7 @@ | |||
| enable = cms.bool(True), | |||
| categories_parameters = cms.PSet( | |||
| # Per-category lepton pt cuts | |||
There was a problem hiding this comment.
Well, I don't understand this commit. I don't remember I touched that intentionally :)
| @@ -57,7 +57,14 @@ | |||
| muonLooseIsoCut = cms.untracked.double(.25), # https://twiki.cern.ch/twiki/bin/view/CMS/TopMUO | |||
| muonTightIsoCut = cms.untracked.double(.15), # https://twiki.cern.ch/twiki/bin/view/CMS/TopMUO | |||
| muonEtaCut = cms.untracked.double(2.4), | |||
| electrons_loose_wp_name = cms.untracked.string("cutBasedElectronID-Summer16-80X-V1-loose"), | |||
| #electrons_loose_wp_name = cms.untracked.string("cutBasedElectronID-Summer16-80X-V1-loose"), #old working point | |||
|
|
|||
No description provided.